This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Set the activation context for the CoreRun application #18728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ined in the target managed assembly. This allows RegFree COM scenarios and ensures the intended app manifest is used for the 'exe' scenario.
|
Work found during planning for #18673 |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…ined (dotnet/coreclr#18728) in the target managed assembly. This allows RegFree COM scenarios and ensures the intended app manifest is used for the 'exe' scenario. Commit migrated from dotnet/coreclr@7222c56
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to what is defined in the target managed assembly. This allows RegFree COM scenarios and ensures
the intended app manifest is used in the 'exe' scenario. The set activation context becomes the default for all subsequent threads and since at this point no other threads exist, this approach in hosting works. I have verified the context is properly inherited by new managed
Threads andTasks.This approach addresses some of the issues related to app.manifests in hosting scenarios. See core-setup#4314 and sdk#1899.
cc @ericstj @luqunl @jkotas