This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Enable Windows ARM64 builds using release product tools #19115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BruceForstall
added
the
* NO MERGE *
BruceForstall
force-pushed
the
dev/unix_test_workflow
branch
from
1e39857
to
399e7b4
Compare
|
@dotnet-bot test ci please |
Remove support for specifying the toolset directory for arm64, which was used to point to an internal toolset. Building for arm64 now works just like the other platforms, e.g. invoke `build arm64`. The requirements: . Visual Studio 2017 Update 4 or later, with ARM64 toolset installed . Windows SDK 10.0.17134.0 or later . CMake 3.10 or later
These will be PR triggered for all users, not just those on the arm64Users list. Since these are Build only, and do no testing, with the change to use public VS2017 build tools, they can be run by anyone. Users on the arm64Users list will still get Checked Build and Test jobs, which require using the private test machines.
BruceForstall
force-pushed
the
dev/unix_test_workflow
branch
from
399e7b4
to
6fc40cc
Compare
|
The arm64 test failure is expected, because the netci.groovy changes aren't used to test the PR. The real testing for this PR is in the dev/unix_test_workflow branch, here: #19242 |
BruceForstall
removed
the
* NO MERGE *
|
The official build machines have also been updated with current tools, and have been tested with this change. |
|
@dotnet/jit-contrib @dotnet/arm64-contrib |
jashook
approved these changes
Aug 2, 2018
| @@ -63,6 +63,24 @@ if (WIN32) | |||
| set(CMAKE_ASM_MASM_COMPILER ${CMAKE_ASM_COMPILER}) | |||
| message("CMAKE_ASM_MASM_COMPILER explicitly set to: ${CMAKE_ASM_MASM_COMPILER}") | |||
|
|
|||
| # Enable generic assembly compilation to avoid CMake generate VS proj files that explicitly | |||
| # use ml[64].exe as the assembler. | |||
| enable_language(ASM) | |||
|
Before we merge this change though we should run the official build as well. |
BruceForstall
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove support for specifying the toolset directory for arm64,
which was used to point to an internal toolset.
Building for arm64 now works just like the other platforms, e.g.
invoke
build arm64.The requirements:
. Visual Studio 2017 Update 4 or later, with ARM64 toolset installed
. Windows SDK 10.0.17134.0 or later
. CMake 3.10 or later