This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Simplify build.sh command line arguments for Linux/arm cross build (Part 1) #20836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ls/gen-buildsys-clang.sh
|
@dotnet-bot test ci please |
|
@dotnet-bot test this please |
|
@BruceForstall @jashook PTAL |
BruceForstall
approved these changes
Nov 12, 2018
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…art 1) (dotnet/coreclr#20836) * Don't use crosscomponent|-crosscomponent command line args in build.sh * Don't use CROSSCOMPONENT environment variable in build.sh src/pal/tools/gen-buildsys-clang.sh * Remove mentioning -crosscomponent from usage() in build-test.sh * Don't use -crosscomponent in buildpipeline * Don't use -crosscomponent in Groovy files * Remove mentioning crosscomponent in Documentation/building/linux-instructions.md * Stop building Hostx86/armel crossgen in build.sh * Disable CrossGen-ing of System.Private.CoreLib on Linux/armel Commit migrated from dotnet/coreclr@e4bfbba
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop using crosscomponent|-crosscomponent in build.sh, buildpipeline, netci.groovy and perf.groovy.
Print a message saying that this is an obsolete command line argument.
Changes in src/pal/tools/gen-buildsys-clang.sh is to make it consistent with src/pal/tools/gen-buildsys-win.bat - DCLR_CROSS_COMPONENTS_BUILD=1 is passed as an extra CMake argument and not determined inside based on presence of CROSSCOMPONENT environment variable.