This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Combine ExcludeList in AltJit scenarios for both host and altjit archs #21018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jashook
approved these changes
Nov 15, 2018
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
dotnet/coreclr#21018) * Add -altjitarch command line argument in tests/runtest.cmd and -altjit_arch in tests/runtest.py * Specify altjitarch in for x86_arm_altjit and x64_arm64_altjit jobs in netci.groovy * Use AltJitArch MSBuild variable in tests/issues.targets to exclude tests based on either BuildArch or AltJitArch since both two JITs are running in altjit scenarios Commit migrated from dotnet/coreclr@356a08f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now during x86_arm altjit scenario we combine all exclusions defined in ExcludeList in issues.targets for BuildArch==x86 (but not for BuildArch==arm). However, some of the tests would fail when arm targeting JIT runs (e.g. #20631).
This change would combine exclusions for both BuildArch and AltJitArch.
@jashook I re-did these PR as you suggested in #20827
Also confirmed in dev/unix_test_workflow that this indeed re-build xunit wrappers during runtest.py and solves the original issue.
Fixes #20631