Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Disable noncollectible alc finalization #21189

Merged

Commits on Nov 20, 2018

  1. Disable noncollectible AssemblyLoadContext finalization

    The constructor of AssemblyLoadContext was missing a call to
    GC.SuppressFinalize for non-collectible AssemblyLoadContext. That means
    that the finalizer can be executed and unloading being initialized even
    for non-collectible AssemblyLoadContext.
    This change fixes that.
    janvorli committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    76cf299 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2018

  1. SuppressFinalize non-collectible AssemblyLoadContext

    The finalizer for the non-collectible AssemblyLoadContext is never
    called and so it should not be in the finalization queue.
    janvorli committed Nov 26, 2018
    Configuration menu
    Copy the full SHA
    cada634 View commit details
    Browse the repository at this point in the history
  2. Handle finalizer call without constructor executed

    Check if the constructor was executed before we run the finalizer code.
    janvorli committed Nov 26, 2018
    Configuration menu
    Copy the full SHA
    3f61a2c View commit details
    Browse the repository at this point in the history
  3. Reflect PR feedback

    janvorli committed Nov 26, 2018
    Configuration menu
    Copy the full SHA
    24137c0 View commit details
    Browse the repository at this point in the history