This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix Rune.ToUpper / ToLower under GlobalizationMode.Invariant #21203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two bugs:
GlobalizationMode.Invariant
is true, leading to behavior like '×' being converted to '÷' during a lowercase operation.GlobalizationMode
flag when using theToUpper
/ToLower
overload that accepts aCultureInfo
parameter, leading to a debug assert inTextInfo.ChangeCaseCommon
.See dotnet/corefx#33698 for the corresponding unit tests.