This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Update changing-corelib.md #21220
Merged
Update changing-corelib.md #21220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
reviewed
Nov 27, 2018
| - Hence, when adding a new public API to System.Private.CoreLib or changing the behavior of the existing public APIs in System.Private.CoreLib, changes must be staged to ensure that new prerequisites are published before they are used. | ||
| ### Context | ||
| Many of the CoreFX libraries type-forward their public APIs to the implementations in `System.Private.CoreLib`. | ||
| - The CoreFX build uses System.Private.CoreLib via a NuGet package named `Microsoft.TargetingPack.Private.CoreCLR` |
There was a problem hiding this comment.
Nit: Enclose System.Private.CoreLib in back ticks like everywhere else?
jkotas
reviewed
Nov 27, 2018
| - Note: if your change is under [System.Private.CoreLib Shared Sources](https://github.com/dotnet/coreclr/tree/master/src/System.Private.CoreLib/shared), it will get mirrored to other repos that are reusing the CoreLib sources. This is a one-way mirror of sources for code reuse purposes: it does not bring your new API to CoreFX so it is not relevant to this staging process. | ||
| - The CoreCLR changes will be consumed by CoreFX via an automatically created PR that updates a hash in the CoreFX repo. These PR's [look like this](https://github.com/dotnet/corefx/pulls?utf8=%E2%9C%93&q=is%3Apr+sort%3Aupdated-desc+coreclr++base%3Amaster+author%3Adotnet-maestro-bot+) | ||
| - Depending on the nature of the change, we may cherry-pick your CoreFX PR into this automatically created PR; or, we may merge your PR after we merge the automatically created PR. | ||
| - Consider creating a new PR against CoreCLR to re-enable any tests you had to disable in your original CoreCLR PR. This can be merged when CoreCLR in turn consumes CoreFX with your chanbges. |
There was a problem hiding this comment.
Consider creating a new PR against CoreCLR to re-enable any tests you had to disable in your original CoreCLR PR. This can be merged when CoreCLR in turn consumes CoreFX with your chanbges.
This does not work today. We are running old fixed CoreFX drop today and thus you cannot re-enable the tests because the test updates are not showing up in the drop used by CoreCLR. (Progress on fixing this is blocked by Azure AD migration.)
jkotas
approved these changes
Nov 27, 2018
jkotas
reviewed
Nov 27, 2018
| Make the changes in both CoreCLR and CoreFX | ||
| - System.Private.CoreLib implementation changes should should be made in CoreCLR repo | ||
| ### (1) Make the changes in both CoreCLR and CoreFX | ||
| - `System.Private.CoreLib` implementation changes should should be made in CoreCLR repo |
There was a problem hiding this comment.
Could you please fix typo: "should should"
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Update changing-corelib.md @jkotas * Update changing-corelib.md Commit migrated from dotnet/coreclr@c98155d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.