This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Replace Interop.ReadDir.cs with Interop.ReadDir.cs from System.IO.FileSystem #21622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
reviewed
Dec 20, 2018
src/System.Private.CoreLib/shared/Interop/Unix/System.Native/Interop.ReadDir.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Dec 20, 2018
jkotas
reviewed
Dec 20, 2018
src/System.Private.CoreLib/shared/Interop/Unix/System.Native/Interop.ReadDir.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Dec 21, 2018
jkotas
reviewed
Dec 21, 2018
jkotas
reviewed
Dec 21, 2018
jkotas
reviewed
Dec 21, 2018
src/System.Private.CoreLib/shared/Interop/Unix/System.Native/Interop.ReadDir.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Dec 21, 2018
jkotas
reviewed
Dec 21, 2018
jkotas
reviewed
Dec 21, 2018
jkotas
reviewed
Dec 21, 2018
src/System.Private.CoreLib/shared/Interop/Unix/System.Native/Interop.ReadDir.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Dec 21, 2018
jkotas
reviewed
Dec 21, 2018
src/System.Private.CoreLib/shared/Interop/Unix/System.Native/Interop.ReadDir.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Dec 21, 2018
src/System.Private.CoreLib/shared/Interop/Unix/System.Native/Interop.ReadDir.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Dec 21, 2018
jkotas
reviewed
Dec 21, 2018
jkotas
reviewed
Dec 21, 2018
jkotas
reviewed
Dec 21, 2018
jkotas
reviewed
Dec 28, 2018
|
@jkotas thanks! learned a lot (as usual) 🙂 |
|
@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test please |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…eSystem (dotnet/coreclr#21622) * Use Interop.ReadDir.cs from FileSystem (corefx) * Use ArrayPool * Remove ReadBufferSize (and static cctor) * use NameBufferSize for 256 const * Delete ReadDir and SafeDirectoryHandle.Unix.cs * Introduce GetDirectoryEntryFullPath, remove uint casts * Refactor EnumerateFilesRecursively Commit migrated from dotnet/coreclr@d70425c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in CoreFX there are two
Interop.ReadDir.cswith slightly different implementationsone is for TimeZoneInfo.Unix.cs and another one is for FileSystemEnumerator.Unix.cs
This PR basically removes one of them (the TimeZoneInfo's one)
It helps us in Mono because we can't have them two inside the mscorlib.