Support building with VS2019 Preview #22525

tannergooding · 2019-02-11T20:00:34Z

Resolves https://github.com/dotnet/coreclr/issues/22446

tannergooding · 2019-02-11T20:01:42Z

Documentation/building/windows-instructions.md

@@ -13,6 +13,7 @@ You must install several components to build the CoreCLR and CoreFX repos. These
 Visual Studio must be installed. Supported versions:
 - [Visual Studio 2015](https://www.visualstudio.com/vs/older-downloads/) (Community, Professional, Enterprise).  The community version is completely free.  
 - [Visual Studio 2017](https://www.visualstudio.com/downloads/) (Community, Professional, Enterprise).  The community version is completely free.  
+- [Visual Studio 2019 Preview](https://visualstudio.microsoft.com/vs/preview/) (Community, Professional, Enterprise).  The community version is completely free.  


The exact workloads required should probably be figured out. It might be worth updating the VS2017 entries as well (as it specifies more than actually required in the latest release).

Documentation/building/windows-instructions.md

tannergooding · 2019-02-11T20:03:03Z

CC. @jashook, @safern

src/pal/tools/gen-buildsys-win.bat

tannergooding · 2019-02-11T20:11:35Z

Worth noting the following warnings:

CMake Deprecation Warning at src/Interop/PInvoke/DllImportPath/CMakeLists.txt:11 (cmake_policy):
  The OLD behavior for policy CMP0037 will be removed from a future version
  of CMake.

  The cmake-policies(7) manual explains that the OLD behaviors of all
  policies are deprecated and that a policy should be set to OLD only under
  specific short-term circumstances.  Projects should be ported to the NEW
  behavior and not rely on setting a policy to OLD.


-- Configuring done
CMake Warning in src/Interop/IJW/ManagedCallingNative/IjwNativeDll/CMakeLists.txt:
  For the target "IjwNativeDll" the /clr compiler flag was added manually.
  Set usage of C++/CLI by setting COMMON_LANGUAGE_RUNTIME target property.


CMake Warning in src/Interop/IJW/NativeCallingManaged/IjwNativeCallingManagedDll/CMakeLists.txt:
  For the target "IjwNativeCallingManagedDll" the /clr compiler flag was
  added manually.  Set usage of C++/CLI by setting COMMON_LANGUAGE_RUNTIME
  target property.

jashook

lgtm thanks for the change!

tannergooding · 2019-02-11T20:18:47Z

Seems there is also an error when compiling the tests:

C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(423,5): error MSB6006: "CL.exe" exited with code -1073740940. [E:\Users\tagoo\Repos\coreclr\bin\tests\obj\Windows_NT.x64.Debug\Native\src\baseservices\exceptions\regressions\Dev11\147911\fpcw.vcxproj]

All other tests compile successfully.

safern

LGTM

…ator

tannergooding · 2019-02-11T21:44:07Z

@jashook, what would you recommend to deal with the singular test project that fails to compile under VS 2019 (see #22525 (comment))?

tannergooding · 2019-02-11T21:55:14Z

It might be worth noting that, refactoring the code file (so that each __try/__except block is in its own method) allows the test to compile. This also makes the test more readable given that there are three different "scenarios" being covered by it.

jashook · 2019-02-11T21:56:54Z

Seems like changing it to allow it to compile seems correct to me. /cc @RussKeldorph opinion?

tannergooding · 2019-02-11T22:01:34Z

I imagine we will want to log a bug with the VC++ team as well.

build-test.cmd

tannergooding · 2019-02-12T00:12:21Z

Added a commit removing the VS2015 support, as per the comment from @jkotas here: #22525 (comment)

I think everything (modulo the VC++ bug, which I am logging now) should be addressed now and this should be ready to merge after the tests complete.

tannergooding · 2019-02-12T00:38:19Z

DevDiv#789922 was logged to track the C++ compiler issue that showed up for regressions\Dev11\147911\fpcw

TylerBrinkley · 2019-03-13T13:28:03Z

Documentation/building/windows-instructions.md

-* Ensure you have installed at least [Visual Studio 2015 Update 3](https://www.visualstudio.com/en-us/news/releasenotes/vs2015-update3-vs).
-* Make sure that you install "VC++ Tools". By default, they will not be installed.
-* To build for Arm32, Make sure that you have the Windows SDK for Windows 10 installed (or selected to be installed as part of VS installation). To explicitly install Windows SDK, download it from here: [Windows SDK for Windows 10](https://developer.microsoft.com/en-us/windows/downloads)
+- [Visual Studio 2019 Preview](https://visualstudio.microsoft.com/vs/preview/) (Community, Professional, Enterprise).  The community version is completely free.  


It should have been noted that the CMake version needs to be 3.14-rc for VS 2019.

* Support building with VS2019 Preview * Fixing gen-buildsys-win to only set the architecture for the VS generator * Refactoring Dev11/147911/fpcw.cpp so that it compiles under VS2019 * Removing the remaining traces of VS2015 build support Commit migrated from dotnet/coreclr@f077060

Support building with VS2019 Preview

03e3fe4

tannergooding commented Feb 11, 2019

View reviewed changes

Documentation/building/windows-instructions.md Outdated Show resolved Hide resolved

sandreenko reviewed Feb 11, 2019

View reviewed changes

src/pal/tools/gen-buildsys-win.bat Outdated Show resolved Hide resolved

jashook approved these changes Feb 11, 2019

View reviewed changes

safern approved these changes Feb 11, 2019

View reviewed changes

sandreenko approved these changes Feb 11, 2019

View reviewed changes

Fixing gen-buildsys-win to only set the architecture for the VS gener…

b27682e

…ator

Refactoring Dev11/147911/fpcw.cpp so that it compiles under VS2019

7c5137b

jkotas reviewed Feb 11, 2019

View reviewed changes

build-test.cmd Outdated Show resolved Hide resolved

Removing the remaining traces of VS2015 build support

3a782e6

tannergooding merged commit f077060 into dotnet:master Feb 12, 2019

tannergooding mentioned this pull request Feb 15, 2019

CoreCLR subscription job is failing dotnet/versions#429

Closed

TylerBrinkley reviewed Mar 13, 2019

View reviewed changes

tannergooding mentioned this pull request Jan 31, 2020

Consider removing build support for VS2015 dotnet/runtime#12017

Closed

hoyosjs mentioned this pull request Jan 31, 2020

VS2019 build doesn't work for x86 dotnet/runtime#12030

Closed

dagood mentioned this pull request Jan 31, 2020

CoreCLR subscription job is failing dotnet/runtime#12054

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support building with VS2019 Preview #22525

Support building with VS2019 Preview #22525

tannergooding commented Feb 11, 2019

tannergooding Feb 11, 2019

tannergooding commented Feb 11, 2019

tannergooding commented Feb 11, 2019

jashook left a comment

tannergooding commented Feb 11, 2019

safern left a comment

tannergooding commented Feb 11, 2019

tannergooding commented Feb 11, 2019

jashook commented Feb 11, 2019

tannergooding commented Feb 11, 2019

tannergooding commented Feb 12, 2019

tannergooding commented Feb 12, 2019 •

edited

Loading

TylerBrinkley Mar 13, 2019 •

edited

Loading

Support building with VS2019 Preview #22525

Support building with VS2019 Preview #22525

Conversation

tannergooding commented Feb 11, 2019

tannergooding Feb 11, 2019

Choose a reason for hiding this comment

tannergooding commented Feb 11, 2019

tannergooding commented Feb 11, 2019

jashook left a comment

Choose a reason for hiding this comment

tannergooding commented Feb 11, 2019

safern left a comment

Choose a reason for hiding this comment

tannergooding commented Feb 11, 2019

tannergooding commented Feb 11, 2019

jashook commented Feb 11, 2019

tannergooding commented Feb 11, 2019

tannergooding commented Feb 12, 2019

tannergooding commented Feb 12, 2019 • edited Loading

TylerBrinkley Mar 13, 2019 • edited Loading

Choose a reason for hiding this comment

tannergooding commented Feb 12, 2019 •

edited

Loading

TylerBrinkley Mar 13, 2019 •

edited

Loading