[master] Update dependencies from dotnet/arcade #24333
Conversation
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
…430.6 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19230.6 - Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19230.6
…501.6 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19251.6 - Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19251.6
…502.2 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19252.2 - Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19252.2
|
@hoyosjs are we blocked on these test failures? |
…503.8 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19253.8 - Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19253.8
…504.1 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19254.1 - Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19254.1
…505.2 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19255.2 - Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19255.2
|
@wtgodbe Looks like init-tools-native is not executable. We could work around this but I'd rather it be fixed in arcade directly. I've made the PR to fix this in dotnet/arcade#2697. As for the R2R failures, I'm not the best person to ask. Maybe @fadimounir can answer that. |
|
I can't really see R2R failures so far (CI still running). Let me know if you see any R2R failure after it completes |
…506.12 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19256.12 - Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19256.12
|
|
…507.7 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19257.7 - Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19257.7
@fadimounir The R2R failures are there now. A lot of file not found errors. |
…508.5 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19258.5 - Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19258.5
|
@jkotas I'm investigating this now. These failures seem pretty odd |
|
I tried re-running one of the tests using the latest master branch, and it all works well. I'm going to try now with this PR's changes. |
|
Not sure what's going on in the CI legs, but I can't repro any of these failures. Looks like transient infra issues (the RunCrossgen mode doesn't have any good cleanup logic) I'll re-run the CI R2R legs |
|
It is not transient. I have rerun it number of times and keeps failing with the same errors every time. |
|
I don't understand why... I'm trying to get a repro environment from helix to dig into this. some files are missing somewhere, and the RunCrossgen logic in each test's cmd runner is extremely fragile |
…509.9 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19259.9 - Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19259.9
|
Looks like the root cause is that the .cmd files that run tests are not executed from the same working dir as the test binaries . That doesn't work well with the R2R script |
|
Still can't figure this out. After being able to repro this locally using the environment from the lab, I added a bunch of echo commands in the test's .cmd file to debug this. I saw some inconsistent output, suggesting the script execution wasn't flowing correctly, and seemed to jump from one place to the other. After adding more echo commands, suddenly it started to work correctly again, and the scripts stdout started to make sense. |
|
Interestingly, found this: https://www.dostips.com/forum/viewtopic.php?p=58890#p58890 |
|
Looks like packaging is creating hangs. Less than a minute on windows and 40 mins in*nix |
…522.13 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19272.13 - Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19272.13 - Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19272.13 - Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19272.13
With the packaging build going through the Arcade scripts now, we probably need to set DisableNativeToolsetInstalls as @sbomer mentioned. |
Like this? de59b67 |
|
@jkotas yes, but it needs to happen whenever |
|
Does the native toolset restore ever work on Unix? It sounds like that it is 100% broken. It should be better disabled in arcade until it actually works. It does not sound right to workaround it it in so many different places and repos. cc @chcosta |
jkotas
force-pushed
the
darc-master-145055cf-390b-45fd-8ad8-3585b3dfc291
branch
from
de59b67
to
5650e58
Compare
|
@hoyosjs The msbuild bug that we have been waiting for a fix for (#24333 (comment)) is back. Does the SDK version that the PR is pointing to have the fix? Do we need to wait for #24756 ? |
…523.11 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19273.11 - Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19273.11 - Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19273.11 - Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19273.11
There's just a couple other repos using the feature, so that might be why they don't see many problems.
It should contain the fix. If it doesn't that definitely warrants taking a look. |
hoyosjs
removed
the
* NO MERGE *
|
The two remaining pipelines finished, the github UI is not updating. |
* Update dependencies from https://github.com/dotnet/arcade build 20190522.13 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19272.13 - Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19272.13 - Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19272.13 - Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19272.13 * Update Unix permissions * Set the versions same way as CoreFX repo * Fix the product branding version * Delete .NET Framework reference assemblies reference * Workaround for dotnet/arcade#2673 Commit migrated from dotnet/coreclr@d3b5e99
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
From https://github.com/dotnet/arcade
From https://github.com/dotnet/arcade
From https://github.com/dotnet/arcade
From https://github.com/dotnet/arcade
From https://github.com/dotnet/arcade
From https://github.com/dotnet/arcade
From https://github.com/dotnet/arcade
From https://github.com/dotnet/arcade
From https://github.com/dotnet/arcade
From https://github.com/dotnet/arcade
From https://github.com/dotnet/arcade