This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Explicitly handle char marshalling in OleVariant::GetNativeMethodTableForVarType. #26218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default handling for
char
marshalling inOleVariant::GetNativeMethodTableForVarType()
doesn't correctly handlechar[]
s marshaled asByValArray
. TheMethodTable*
calculates forchar
elements doesn't correctly account forCharSet
.In master, this code-path is only executed as part of SystemV classification of by-val arrays, so it requires a contrived struct to encounter, such as the one below:
Currently, this classifies the first eight bytes as
INTEGER
and the second eight bytes asSSE
. However, both eight bytes should be classified asINTEGER
since the char array extends into the second eight byte.I discovered this bug as part of my work on unifying the struct marshaling with the parameter and return value marshaling where I am using the
OleVariant::GetNativeMethodTableForVarType()
in more locations.