This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Add ability to only copy native test files to managed tests in build-test scripts #26451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rojects that need them in a way separate from the managed test build.
jashook
approved these changes
Aug 30, 2019
trylek
approved these changes
Aug 30, 2019
|
This test failure is showing up in multiple PRs. Since this PR makes no changes to the process for running CoreFX tests, I'm going to merge it in. |
jkoritzinsky
deleted the
optional-individual-native-test-binary-copying
branch
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…test scripts (dotnet/coreclr#26451) * Add MSBuild targets neccesary to copy native test assets to managed projects that need them in a way separate from the managed test build. * Hook up native test binary copying through build-test scripts. * Unix script changes/cleanup * Remove unconditional generatelayout in runtest.sh * Add new options to usage Commit migrated from dotnet/coreclr@05c6400
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of supporting #26404, this PR adds additional arguments to
build-test.cmdandbuild-test.shto enable only copying native test binaries to their respective managed test output directory without building tests. Additionally, it adds another parameter to support skipping generating the Core_Root layout and the CoreFX test host, which can also be used as part of #26404.To skip the native and managed builds and copy the native assets to the managed test output directory, use the
copynativeonlyparameter tobuild-test. To skip setting up Core_Root and the CoreFX test host, useskipgeneratelayout.This PR also changes runtest.sh to not generate the Core_Root layout when not told where to find Core_Root.
cc: @dotnet/coreclr-infra