This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix update versions logic #26768
Merged
Fix update versions logic #26768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After dotnet#26108, this was broken because the Tools.proj was never restored on the agent running the finalize-publish job. This fixes the script to do a restore, and adds a missing import.
jkoritzinsky
approved these changes
Sep 18, 2019
elinor-fung
approved these changes
Sep 18, 2019
UpdatePublishedVersions.ps1
Outdated
| /p:UsePartialNGENOptimization=false ` | ||
| /maxcpucount ` | ||
| "$PSScriptRoot\eng\updateversions.proj" /t:UpdatePublishedVersions ` | ||
| & "$PSScriptRoot\eng\common\build.ps1" -restore -build ` |
There was a problem hiding this comment.
Since this script doesn't have to do build tools initialization now, is there a reason for us to still have a separate script instead of just having the step in yml call build.ps1 directly?
There was a problem hiding this comment.
Should we also pass -ci? Considering this is mean only for use in the pipeline?
eng/updateversions.proj
Outdated
| @@ -6,6 +6,10 @@ | |||
|
|
|||
| <Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.props', '$(MSBuildThisFileDirectory)../'))" /> | |||
|
|
|||
| <Import Project="$(NuGetPackageRoot)\microsoft.dotnet.versiontools.tasks\$(MicrosoftDotNetVersionToolsTasksPackageVersion)\build\Microsoft.DotNet.VersionTools.Tasks.props" /> | |||
There was a problem hiding this comment.
Do we still need to add Microsoft.DotNet.VersionTools.Tasks as a repo dependency for auto-updates? (I don't see it in Version.Details.xml)
hoyosjs
approved these changes
Sep 18, 2019
UpdatePublishedVersions.ps1
Outdated
| /p:UsePartialNGENOptimization=false ` | ||
| /maxcpucount ` | ||
| "$PSScriptRoot\eng\updateversions.proj" /t:UpdatePublishedVersions ` | ||
| & "$PSScriptRoot\eng\common\build.ps1" -restore -build ` |
There was a problem hiding this comment.
Should we also pass -ci? Considering this is mean only for use in the pipeline?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #26108, this was broken
because the Tools.proj was never restored on the agent running the
finalize-publish job. This fixes the script to do a restore, and adds
a missing import.
@dotnet/coreclr-infra PTAL