Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Various tailcall test improvements #26818

Merged
merged 16 commits into from
Sep 25, 2019
Merged

Various tailcall test improvements #26818

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
8e0bdc1
Remove some illegal tailcall tests
jakobbotsch Sep 21, 2019
83f8e00
Add some more tailcall tests
jakobbotsch Sep 20, 2019
afc2be6
Improve tailcall hijacking test
jakobbotsch Sep 13, 2019
45c32d7
Clarify some reasons for some disabled tests
jakobbotsch Sep 21, 2019
05db47e
Disable new test on everything except x86 Windows
jakobbotsch Sep 23, 2019
3b09b8c
Add another arg to TailHelper2 to ensure helper-based tailcall on SysV
jakobbotsch Sep 23, 2019
4109f4c
Disable hijacking test on anything except x86/x64 Windows
jakobbotsch Sep 23, 2019
cee0ae2
Update more tailcalls test and add source file
jakobbotsch Sep 24, 2019
0cc86b9
Pinvoke printf for Unix in TailcallVerifyWithPrefix test
jakobbotsch Sep 24, 2019
070ff53
Clean up TailcallVerifyWithPrefix test
jakobbotsch Sep 24, 2019
163bf2b
Clean up reasons for disabling TailcallVerifyWithPrefix
jakobbotsch Sep 24, 2019
1174e5a
Update a reason
jakobbotsch Sep 24, 2019
1502e1a
Remove more dead code in TailcallVerifyWithPrefix.il
jakobbotsch Sep 24, 2019
1f900e2
Fix wrong IL in TailcallVerifyWithPrefix test
jakobbotsch Sep 24, 2019
4a54ade
Add a comment describing more_tailcalls.cs
jakobbotsch Sep 25, 2019
413dd6d
Clarify issue number
jakobbotsch Sep 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Clarify issue number
  • Loading branch information
@jakobbotsch
jakobbotsch committed Sep 25, 2019
commit 413dd6dca5bb99ba6b387d5d9194a8d61858fbad
2 changes: 1 addition & 1 deletion tests/issues.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -897,7 +897,7 @@
<!-- Tests that run only on x86 Windows -->
<ItemGroup Condition="'$(XunitTestBinBase)' != '' and ('$(BuildArch)' != 'x86' or '$(TargetsWindows)' != 'true')">
<ExcludeList Include="$(XunitTestBinBase)/JIT/Directed/tailcall/more_tailcalls/*">
<Issue>x64 Windows has bugs with helper-based tailcall to VSD; rest of platforms do not support it</Issue>
<Issue>x64 Windows has bugs with helper-based tailcall to VSD (#26311); rest of platforms do not support it</Issue>
</ExcludeList>
</ItemGroup>
<!-- runtest.proj finds all the *.cmd/*.sh scripts in a test folder and creates corresponding test methods.
Expand Down