Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Add csproj and bash script for crossgen2 ThunkGenerator #26916

Merged
merged 2 commits into from
Oct 7, 2019

Conversation

jakobbotsch
Copy link
Member

I have had to run this from Linux twice and both times I have had to create a csproj first because even using the csc that comes with the SDK does not automatically add the needed references.

PTAL @MichalStrehovsky

Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

The reason why it wasn't a csproj is that dotnet run generates a ton of garbage temporary files that don't cleaned up. But I guess we can live with that.

@jashook
Copy link

jashook commented Oct 7, 2019

@MichalStrehovsky is this good to go?

@MichalStrehovsky MichalStrehovsky merged commit 58084a2 into dotnet:master Oct 7, 2019
@MichalStrehovsky
Copy link
Member

@MichalStrehovsky is this good to go?

Yup, merged. Sorry for the delay.

@jakobbotsch jakobbotsch deleted the crossgen2-csproj branch October 7, 2019 16:13
SrivastavaAnubhav pushed a commit to SrivastavaAnubhav/coreclr that referenced this pull request Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants