Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Improve Dictionary TryGetValue size/perfomance #27195

Merged
merged 8 commits into from
Oct 16, 2019
Merged

Improve Dictionary TryGetValue size/perfomance #27195

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b40e8aa
Dictionary avoid second bounds check in Get methods
benaadams Oct 15, 2019
cb70550
Add NullRef methods to Unsafe
benaadams Oct 15, 2019
996524e
nits
benaadams Oct 15, 2019
18a0ca8
Use uint
benaadams Oct 16, 2019
3507078
Make methods public
benaadams Oct 16, 2019
bbf8fc7
Apply suggestions from code review
benaadams Oct 16, 2019
7686383
nit
benaadams Oct 16, 2019
92f3f09
Add to crossgen2
benaadams Oct 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-Authored-By: Jan Kotas <jkotas@microsoft.com>
  • Loading branch information
@benaadams @jkotas
benaadams and jkotas committed Oct 16, 2019
commit bbf8fc787305447d520b0e640f5b8a47e3e9c828
4 changes: 2 additions & 2 deletions src/System.Private.CoreLib/shared/System/Collections/Generic/Dictionary.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ public void Clear()
}
}

public unsafe bool ContainsKey(TKey key)
public bool ContainsKey(TKey key)
=> !Unsafe.IsNullRef(ref FindValue(key));

public bool ContainsValue(TValue value)
Expand Down Expand Up @@ -891,7 +891,7 @@ public bool Remove(TKey key, [MaybeNullWhen(false)] out TValue value)
return false;
}

public unsafe bool TryGetValue(TKey key, [MaybeNullWhen(false)] out TValue value)
public bool TryGetValue(TKey key, [MaybeNullWhen(false)] out TValue value)
{
ref TValue valRef = ref FindValue(key);
if (!Unsafe.IsNullRef(ref valRef))
Expand Down