This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Create CONTRIBUTING.md #6386
Merged
Create CONTRIBUTING.md #6386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file exists in corefx and is an obvious file to look for. Making the two repos the same.
|
LGTM. In the future, please create a branch in your own fork instead of on the main repo when sending a PR, so that everyone who's pulling from the repo doesn't get your branch. |
|
I've opened an issue for the Windows test failure: https://github.com/dotnet/coreclr/issues/6397 Feel free to ignore it; I'm going to assume this change didn't break threading. 😄 |
|
Fair enough on the additional branch. I have my own fork. I'll use it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file exists in corefx and is an obvious file to look for. Making the two repos the same.