This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Change warning to error for future test asset framework issues #6535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dagood rerunning the tests on this old PR so hopefully you can merge it. |
|
@dotnet-bot test this please |
sergign60
pushed a commit
to sergign60/coreclr
that referenced
this pull request
Nov 14, 2016
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the type of warning seen in https://github.com/dotnet/coreclr/issues/6022 into an error so it won't get reintroduced. The warnings were fixed in #6479 by upgrading to
netcoreapp1.0.I wouldn't say this is a fix for https://github.com/dotnet/coreclr/issues/5784, because there are still other warnings. (But it's a step.)
/cc @RussKeldorph @ericstj