This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Bring to CoreCLR the SecureString implementation from CoreFx. #7884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexGhiondea
force-pushed
the
Port_SecureString
branch
from
f544a8c
to
ff7437d
Compare
|
/cc @JeremyKuhne @jkotas |
JeremyKuhne
suggested changes
Oct 28, 2016
|
|
||
| private unsafe void InitializeSecureString(char* value, int length) | ||
| { | ||
| BCLDebug.Assert(length >= 0, $"Expected non-negative length, got {length}"); |
There was a problem hiding this comment.
Ah - yes! When I originally ported this, your change was not there :).
Will change it!
JeremyKuhne
approved these changes
Oct 29, 2016
justinvp
reviewed
Oct 29, 2016
| // Make sure the requested capacity doesn't exceed SecureString's defined limit | ||
| if (capacity > MaxLength) | ||
| { | ||
| throw new ArgumentOutOfRangeException("capacity", SR.ArgumentOutOfRange_Capacity); |
There was a problem hiding this comment.
Nit: nameof(capacity)? (I see there are some other uses of nameof in this change, so presumably this language feature can be used in corelib.)
stephentoub
reviewed
Oct 29, 2016
| <Member Name="MakeReadOnly" /> | ||
| <Member Name="RemoveAt(System.Int32)" /> | ||
| <Member Name="SetAt(System.Int32,System.Char)" /> | ||
| </Type> |
There was a problem hiding this comment.
What about SecureStringMarshal?
stephentoub
reviewed
Oct 29, 2016
| namespace System.Security.Cryptography | ||
| { | ||
| [Serializable] | ||
| public class CryptographicException : SystemException |
There was a problem hiding this comment.
So are we now exposing CryptographicException from coreclr as well? Presumably it needs to be added to model.xml as well then?
There was a problem hiding this comment.
I added them both to model.xml.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this is checked in there is work remaining in CoreFx: