This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Temporarily removing leftover use of ReadOnlySpan indexer. #25908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What are you doing to find these? Is this the final set? LGTM otherwise. |
Yes, this is the final set. I was running the ProjectN test set. |
|
@dotnet-bot test Windows x64 Debug Build |
This was referenced Dec 14, 2017
ahsonkhan
added a commit
to ahsonkhan/corefx
that referenced
this pull request
Dec 16, 2017
…otnet#25908)" This reverts commit bbe425e.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…refx#25908) * Temporarily removing leftover use of ReadOnlySpan indexer. * Fixing some typos and marking method as unsafe. Commit migrated from dotnet/corefx@bbe425e
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…otnet/corefx#25908)" This reverts commit dotnet/corefx@bbe425e. Commit migrated from dotnet/corefx@4c6a847
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to:
#25326
#25881
Removing the use of the ReadOnlySpan indexer to help the implementation change go through with the least disabling of tests.
This is a temporary workaround that is required to reduce the number of failing tests that would need to be disabled due to the change to ReadOnlySpan indexer to return ref readonly (in coreclr and in .NET Native)
cc @weshaggard, @stephentoub, @KrzysztofCwalina, @jkotas, @botaberg, @zamont
This change should be reverted once the change propagates