Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Convert all projects to SDK-style #29831

Merged
merged 27 commits into from
Jul 8, 2018
Merged

Convert all projects to SDK-style #29831

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
91d7e62
Convert all .csproj files in src to SDK-style projects
wtgodbe May 21, 2018
be0421d
Add Directory.build.props/targets
wtgodbe May 21, 2018
f60fa38
Add project.assets.json & edit properties
wtgodbe May 21, 2018
10b7151
Remove project.assets.json file
wtgodbe May 21, 2018
3ecd281
Get netcoreapp build working.
eerhardt Jun 11, 2018
ad505eb
Merge master into SdkProj
eerhardt Jun 11, 2018
be5ceb5
Clean up projects. Get all projects importing clean with no warnings…
eerhardt Jun 12, 2018
204a8db
Rename dir files to Directory.Build
eerhardt Jun 15, 2018
1c91f96
merge master into SdkProj
eerhardt Jun 16, 2018
3b36996
Small fixes to get the build clean.
eerhardt Jun 16, 2018
b09b0b5
Fix AssemblySearchPaths on the Microsoft.NET.Sdk.
eerhardt Jun 16, 2018
67dacd6
Ensure csc command line is the same as before converting to Sdk proje…
eerhardt Jun 19, 2018
0c7364e
Merge master into SdkProj
eerhardt Jun 19, 2018
53d5973
Fix FileVersionInfo build
eerhardt Jun 19, 2018
6d25667
Rephrase Directory.Build comments to better describe why ImportDirect…
eerhardt Jun 20, 2018
e05508a
Change .csproj to new Configurations property
eerhardt Jun 28, 2018
9f65193
Turn off ILLinkTrimAssembly during design-time builds.
eerhardt Jun 29, 2018
ec546de
Merge master into SdkProj
eerhardt Jun 29, 2018
860888c
Fix up Reflection.Context dir.props/targets to Directory.Build.
eerhardt Jun 29, 2018
6ccae92
Revert WebServer change, since it cannot be an SDK style project.
eerhardt Jun 29, 2018
0343b37
Merge master into SdkProj
eerhardt Jul 5, 2018
1a4b8a2
Run UpdateVSConfigurations on the current code.
eerhardt Jul 5, 2018
9b7b8c0
Fix up new projects and usages of dir.props/targets.
eerhardt Jul 5, 2018
e72643b
Merge master into SdkProj
eerhardt Jul 6, 2018
aa89672
Set TargetFramework to workaround project system bug.
eerhardt Jul 6, 2018
b86cade
Merge remote-tracking branch 'upstream/master' into SdkProj
eerhardt Jul 6, 2018
99e21e6
Merge master into SdkProj
eerhardt Jul 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Set TargetFramework to workaround project system bug.
  • Loading branch information
@eerhardt
eerhardt committed Jul 6, 2018
commit aa89672cb15f11f711ba4c0232b88b706ffe736f
5 changes: 5 additions & 0 deletions src/Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,4 +58,9 @@
<Message Text="DumpTargets> $(OutputPath), C=[$(Configuration)], CG=[$(ConfigurationGroup)], OG=[$(OSGroup)], TG=[$(TargetGroup)]" Importance="Low" />
</Target>

<PropertyGroup>
<!-- Workaround https://github.com/dotnet/project-system/issues/3670 by setting TargetFramework expicitly -->
<!-- This property is set late in the project evaluation so other properties don't try to use it. -->
<TargetFramework>$(TargetGroup)</TargetFramework>
</PropertyGroup>
</Project>