This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Annotate System.Runtime.CompilerServices.Unsafe for nullable reference types #41855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
commented
Oct 17, 2019
src/System.Runtime.CompilerServices.Unsafe/ref/Configurations.props
Outdated
Show resolved
Hide resolved
stephentoub
force-pushed
the
nullableunsafe
branch
2 times, most recently
from
65dd7ca
to
47bbb75
Compare
…e types The actual implementation is in IL, and there'd be no benefit to adding annotations there, so I've only annotated the C# ref assembly.
stephentoub
force-pushed
the
nullableunsafe
branch
from
47bbb75
to
7804341
Compare
safern
approved these changes
Oct 17, 2019
sharwell
reviewed
Oct 17, 2019
src/System.Runtime.CompilerServices.Unsafe/ref/System.Runtime.CompilerServices.Unsafe.cs
Show resolved
Hide resolved
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…e types (dotnet/corefx#41855) * Annotate System.Runtime.CompilerServices.Unsafe for nullable reference types The actual implementation is in IL, and there'd be no benefit to adding annotations there, so I've only annotated the C# ref assembly. * Address PR feedback Commit migrated from dotnet/corefx@a7b4117
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to https://github.com/dotnet/corefx/issues/40623
cc: @buyaa-n, @safern
The actual implementation is in IL, and there'd be no benefit to adding annotations there, so I've only annotated the C# ref assembly.