Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorg tutorials toc #18515

Merged
merged 6 commits into from
May 22, 2020
Merged

Reorg tutorials toc #18515

merged 6 commits into from
May 22, 2020

Conversation

tdykstra
Copy link
Contributor

Fixes #18505

@tdykstra tdykstra requested a review from BillWagner May 19, 2020 20:25
@tdykstra tdykstra marked this pull request as ready for review May 19, 2020 20:45
@tdykstra tdykstra requested a review from a team as a code owner May 19, 2020 20:45
@tdykstra tdykstra removed the request for review from a team May 19, 2020 20:46
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @tdykstra

You can :shipit: when ready.

@tdykstra tdykstra requested a review from BillWagner May 20, 2020 16:22
@tdykstra
Copy link
Contributor Author

@BillWagner I tweaked it a little more, please take another look when you have a chance.

@tdykstra tdykstra merged commit f88b136 into dotnet:master May 22, 2020
@tdykstra tdykstra deleted the tutorialstoc branch May 22, 2020 16:20
- name: Create a .NET Core app with plugins
href: tutorials/creating-app-with-plugin-support.md
- name: Develop ASP.NET Core apps
href: tutorials/aspnet-core.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tdykstra Was this tutorial excluded from the updated TOC on purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plugins moved to the Advanced section. ASP.NET Core is included in "More tutorials"

  - name: More tutorials
    href: tutorials/index.md

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was referring to aspnet-core.md, sorry. I don't see it in https://raw.githubusercontent.com/dotnet/docs/master/docs/core/tutorials/index.md.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ASP.NET Core is covered by these lines

## Create web apps

For tutorials about developing ASP.NET Core web applications, see the [ASP.NET Core documentation](/aspnet/core/).

aspnet-core.md should have been deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restructure .NET Core tutorials toc
4 participants