Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ValueTask and ConfigureAwait details to "info & advice" #18527

Merged
merged 6 commits into from
May 20, 2020
Merged

Add ValueTask and ConfigureAwait details to "info & advice" #18527

merged 6 commits into from
May 20, 2020

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented May 20, 2020 •
edited
Loading

Summary

  • General clean up of article
    • Acrolinx
    • Sentence case headings
    • Add some xref's
    • Add link to ConfigureAwait FAQ
    • Add code fence around missing segments
    • Correctly tab C#
    • Replace " " double space after sentences, with " " single space
    • Format table
  • Added ValueTask and ConfigureAwait in "info & advice"

Fixes #18225

Preview

✔️ Asynchronous programming

@dotnet-bot dotnet-bot added this to the May 2020 milestone May 20, 2020
@IEvangelist IEvangelist self-assigned this May 20, 2020
@IEvangelist IEvangelist requested a review from gewarren May 20, 2020 17:38
gewarren
gewarren approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a number of suggestions.

docs/csharp/async.md Outdated Show resolved Hide resolved
docs/csharp/async.md Outdated Show resolved Hide resolved
docs/csharp/async.md Outdated Show resolved Hide resolved
docs/csharp/async.md Outdated Show resolved Hide resolved
docs/csharp/async.md Outdated Show resolved Hide resolved
docs/csharp/async.md Outdated Show resolved Hide resolved
docs/csharp/async.md Outdated Show resolved Hide resolved
docs/csharp/async.md Outdated Show resolved Hide resolved
docs/csharp/async.md Outdated Show resolved Hide resolved
docs/csharp/async.md Outdated Show resolved Hide resolved
@IEvangelist @gewarren
Apply suggestions from code review
03fd0ac 
Co-authored-by: Genevieve Warren <gewarren@microsoft.com>
gewarren
gewarren reviewed May 20, 2020
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a couple more things on the preview.

docs/csharp/async.md Outdated Show resolved Hide resolved
docs/csharp/async.md Outdated Show resolved Hide resolved
docs/csharp/async.md Outdated Show resolved Hide resolved
IEvangelist and others added 2 commits May 20, 2020 16:16
@IEvangelist @gewarren
Apply suggestions from code review
b0e7ea3 
Co-authored-by: Genevieve Warren <gewarren@microsoft.com>
@IEvangelist
More updates from peer review
f173b9e
@IEvangelist IEvangelist merged commit d4c0bbb into dotnet:master May 20, 2020
@IEvangelist IEvangelist deleted the async-bits branch May 20, 2020 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren approved these changes

@BillWagner BillWagner Awaiting requested review from BillWagner

Assignees

@IEvangelist IEvangelist

Labels
dotnet-csharp/svc
Projects
None yet
Milestone
May 2020
Development

Successfully merging this pull request may close these issues.

Additional Advice: ConfigureAwait and ValueTask
4 participants
@IEvangelist @gewarren @BillWagner @dotnet-bot