Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Aspire to 8.0.0-preview.2.23611.9 #136

Merged
merged 8 commits into from
Dec 21, 2023
Merged

Conversation

captainsafia
Copy link
Member

@captainsafia captainsafia commented Dec 14, 2023

This PR relies on non-nuget.org sources at the moment.

@captainsafia captainsafia force-pushed the safia/update-aspire-p2 branch 5 times, most recently from 0d05f45 to a5abdf6 Compare December 14, 2023 18:08
@davidfowl davidfowl added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Dec 14, 2023
@captainsafia
Copy link
Member Author

When running this locally on my macOS, I'm observing the following behavior:

Application host starts up successfully:

dotnet run --project src/eShop.AppHost/eShop.AppHost.csproj 
Building...
info: Aspire.Dashboard.DashboardWebApplication[0]
      Now listening on: http://localhost:18848
info: Aspire.Dashboard.DashboardWebApplication[0]
      OTLP server running at: http://localhost:16119
info: Microsoft.Hosting.Lifetime[0]
      Application started. Press Ctrl+C to shut down.
info: Microsoft.Hosting.Lifetime[0]
      Hosting environment: Development
info: Microsoft.Hosting.Lifetime[0]
      Content root path: /Users/captainsafia/gh/eShop/src/eShop.AppHost

Docker containers successfully launch:

image

Containers are reported as stuck on Starting...

image

And no logs are present in the dashboard. postgres says it failed to initialize even though the Docker container is successfully running:

image

Also, not all the projects launch.

Copy link
Member Author

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Can't approve a PR I opened but this builds on my machine and I was able to complete the purchase flow successfully.

@davidfowl davidfowl removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Dec 21, 2023
nuget.config Outdated Show resolved Hide resolved
Copy link
Member

@davidfowl davidfowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be good now

@davidfowl
Copy link
Member

Lets clean up the nuget feed.

@captainsafia captainsafia merged commit 33fe40d into main Dec 21, 2023
3 checks passed
@captainsafia captainsafia deleted the safia/update-aspire-p2 branch December 21, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants