Serve product images from WebApp, so CatalogApi doesn't have to be publicly reachable #74
Conversation
SteveSandersonMS
requested review from
adityamandaleeka,
Eilon and
jamesmontemagno
|
as this was done from a private fork, I believe you now need to delete that fork (keep clone locally!) then re-fork now this repo is public, push original branch up, then close this PR and create a new one from your new public fork. |
|
@danmoseley It doesn't look like this was done from a private fork to me? Or did something change after you posted that comment? |
src/WebApp/Extensions/Extensions.cs
Outdated
| app.MapGet("/product-images/{id:int}", async (IHttpClientFactory httpClientFactory, int id) => | ||
| { | ||
| var httpClient = httpClientFactory.CreateClient(ProductImageProxyHttpClient); | ||
| var imageResponse = await httpClient.GetAsync($"/api/v1/catalog/items/{id}/pic"); |
There was a problem hiding this comment.
Can/should Yarp be used for this? That's what "eshopLite" does: https://github.com/dotnet/aspire/blob/cb54d832ce8328c2ac681b031a8c0e0d0f709a7e/samples/eShopLite/MyFrontend/Program.cs#L31
There was a problem hiding this comment.
Oh that's very nice. I started by trying to do this with Yarp but didn't discover the MapForwarder method, and got lost in the weeds with LoadFromMemory, trying to call PathSet and all kinds of mess. I did make it work in the end but then it was super unclear how to wire it up to service discovery, so I thought it was better not to introduce all that for this sample.
I'll have another go with MapForwarder. Is there an example of using this with service discovery somewhere? It needs to be able to make an outbound request to http://catalogapi so it needs to use an HttpClient that knows about this.
There was a problem hiding this comment.
Is there an example of using this with service discovery somewhere?
Yep! The same app uses the Microsoft.Extensions.ServiceDiscovery.Yarp package as well. See https://github.com/dotnet/aspire/blob/ab931f067195a7af0468c18974b864c51a2963cd/samples/eShopLite/MyFrontend/Program.cs#L9
There was a problem hiding this comment.
Excellent, thanks. It works perfectly - this PR now uses that.
|
Ah I saw stevesa: but it's stevesa/ |
SteveSandersonMS
force-pushed
the
stevesa/proxy-images
branch
from
7714cca
to
fa6d920
Compare
|
This is now complete, in that WebApp and HybridApp are both updated to get the images via proxies instead of having the client reference URLs on catalog-api, so I'll merge. I don't know whether the MAUI app needs a similar change to avoid referencing catalog-api directly from the client but if so that can be handled separately (cc @jamesmontemagno). |
|
Looks like merging now requires an approval. @Eilon can you approve this, since you've already been through all this code and wrote part of it? |
Fixes #31
This will require more collaboration:
HybridAppproject. That app is going to need to start knowing the URL toWebAppso it can fetch product images from there, or theMobile.Bff.Shoppingproject could be changed to override thePictureUrivalues on products so it points toWebApp, using the URL pattern/product-images/{id}.HybridAppshares theCatalogListItem.razorcomponent. I've introduced a new interface,IProductImageUrlProvider, for whichHybridAppcan provide an implementation that returns URLs onWebApp.WebApphas an implementation of that interface, but it doesn't need to know absolute URLs because the whole point here is that on the web, you're getting the images from the same origin.item.PictureUri, that will be incorrect because we need to stop assuming that CatalogApi is publicly reachable. Most likely it should be changed to fetch the product images fromWebAppinstead, using the URL pattern/product-images/{id}.Given this complexity, I'm not sure we should do this at the last minute, though I do agree it's a change we should make when possible.