Add PR validation GitHub Action #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmoseley
reviewed
Nov 14, 2023
danmoseley
reviewed
Nov 14, 2023
Directory.Packages.props
Outdated
| @@ -33,7 +33,7 @@ | |||
| <PackageVersion Include="Microsoft.AspNetCore.TestHost" Version="$(AspnetVersion)" /> | |||
| <PackageVersion Include="Microsoft.Extensions.Diagnostics.HealthChecks" Version="$(AspnetVersion)" /> | |||
| <PackageVersion Include="Microsoft.Extensions.Identity.Stores" Version="$(AspnetVersion)" /> | |||
| <PackageVersion Include="Microsoft.Extensions.Http.Resilience" Version="8.0.0-rtm.23524.3" /> | |||
| <PackageVersion Include="Microsoft.Extensions.Http.Resilience" Version="8.0.0" /> | |||
There was a problem hiding this comment.
nit, extract <MicrosoftExtensionsVersion> maybe?
danmoseley
reviewed
Nov 14, 2023
Directory.Packages.props
Outdated
| @@ -33,7 +33,7 @@ | |||
| <PackageVersion Include="Microsoft.AspNetCore.TestHost" Version="$(AspnetVersion)" /> | |||
| <PackageVersion Include="Microsoft.Extensions.Diagnostics.HealthChecks" Version="$(AspnetVersion)" /> | |||
| <PackageVersion Include="Microsoft.Extensions.Identity.Stores" Version="$(AspnetVersion)" /> | |||
| <PackageVersion Include="Microsoft.Extensions.Http.Resilience" Version="8.0.0-rtm.23524.3" /> | |||
| <PackageVersion Include="Microsoft.Extensions.Http.Resilience" Version="8.0.0" /> | |||
There was a problem hiding this comment.
also <PackageVersion Include="Microsoft.AspNetCore.Identity.EntityFrameworkCore" Version="8.0.0-rc.2.23480.2" /> .. should use $(AspnetVersion) ?
There was a problem hiding this comment.
I tried to avoid making too many version upgrades here to avoid rocking the boat but this one seems safe to do. There are other places where we reference RC packages but we should look at those more closely.
danmoseley
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.