Updating MediatR and switching to keyed services #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfowl
reviewed
Nov 17, 2023
…since it is using keyed services
davidfowl
reviewed
Nov 22, 2023
| @@ -200,16 +200,8 @@ private async Task ProcessEvent(string eventName, string message) | |||
| // REVIEW: This could be done in parallel | |||
|
|
|||
| // Get all the handlers using the event type as the key | |||
| // foreach (var handler in scope.ServiceProvider.GetKeyedServices<IIntegrationEventHandler>(eventType)) | |||
|
|
|||
| _subscriptionInfo.HandlerTypes.TryGetValue(eventType, out var handlerTypes); | |||
There was a problem hiding this comment.
Does the keyed services not replace the whole HandlerTypes business? That you don't need to keep track of all the handler types to resolve, you rely on the container instead.
davidfowl
approved these changes
Nov 25, 2023
|
Thanks @jbogard ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this issue called out by @davidfowl : https://x.com/davidfowl/status/1725559031484555616?s=20
Pretty neat way of approaching the design, too.