Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing nuget package Microsoft.EntityFrameworkCore.Relational.Specification.Tests #34221

Closed
ChrisJollyAU opened this issue Jul 13, 2024 · 5 comments · Fixed by #34228
Closed
Labels
area-shipping closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-bug

Comments

@ChrisJollyAU
Copy link
Contributor

I'm busy trying to upgrade EntityFrameworkCore.Jet to the latest preview of efcore 9 - preview 6.

I'm getting stuck when trying to update the references for the tests. Specifically the tests reference the package Microsoft.EntityFrameworkCore.Relational.Specification.Tests but preview 3 is the latest available on nuget - see https://www.nuget.org/packages/Microsoft.EntityFrameworkCore.Relational.Specification.Tests/

Is there a change in design that we need to reference a different nuget package or is this just something that got missed during the previews

Potentially this affects all third party ef core providers

@ajcvickers
Copy link
Member

@SamMonoRT Looks like an issue with the build/publishing.

@SamMonoRT
Copy link
Member

@rbhanda @leecow - would you know why this test package is stuck on Preview 3 -- https://www.nuget.org/packages/Microsoft.EntityFrameworkCore.Relational.Specification.Tests/#versions-body-tab ?

@leecow
Copy link
Member

leecow commented Jul 15, 2024

It looks like that package is marked as non-shipping so doesn't get picked up by the publishing process. We should be able to manually push it to NuGet but you'll need to work out why it's not marked as "shipping".

@AndriySvyryd
Copy link
Member

I don't know how it was "shipping" before, but we explicitly marked EFCore.Specification.Tests as shipping in ec29172, but missed EFCore.Relational.Specification.Tests

@AndriySvyryd AndriySvyryd added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. and removed needs-design labels Jul 15, 2024
@AndriySvyryd AndriySvyryd added this to the 9.0.0 milestone Jul 15, 2024
@AndriySvyryd AndriySvyryd removed their assignment Jul 15, 2024
@ChrisJollyAU
Copy link
Contributor Author

Thanks. Looks like that has done the trick. The packages are there now in nuget and have also now started appearing again in the dotnet9 daily build feed as of 9.0.0-preview.7.24366.1 with the previous package all the way back in April as 9.0.0-preview.4.24210.1

Just a bit of natural curiosity - All the other packages for preview 6 are with build number 24327, however this one you just pushed (Microsoft.EntityFrameworkCore.Relational.Specification.Tests) is 24322. Any particular reason? Only reason I picked it up was I was setting the version with $(EFCoreVersion). Its easy enough to specify the exact version for that dependency and since the builds are so close together there shouldn't be anything incompatible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-shipping closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants