Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement translation for XOR #34071

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Implement translation for XOR #34071

merged 3 commits into from
Jun 24, 2024

Conversation

ranma42
Copy link
Contributor

@ranma42 ranma42 commented Jun 23, 2024

Fixes #16645.

Based on previous work by @roji.

@ranma42
Copy link
Contributor Author

ranma42 commented Jun 23, 2024

SQLite does not implement bitwise XOR natively, but it would be easy to add it as a custom function. The XOR between bool expressions could also be implemented as a !=, just like in Cosmos.

SQLServer could take advantage of this to improve (in some cases) the translation of NOT.

This PR only adds the basic implementation (no optimizations/simplifications).

@cincuranet cincuranet merged commit 7e313ab into dotnet:main Jun 24, 2024
7 checks passed
@ranma42 ranma42 deleted the bitwise-xor branch June 24, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query: Bitwise Ex-Or support
3 participants