Cosmos: strip implicit casts to allow vector search over arrays #34437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
force-pushed
the
CosmosVectorStuff
branch
from
258020d
to
5136903
Compare
|
@roji This is now hacked to allow both arrays and read-only-memories without appropriate overloads or type mappings. |
roji
commented
Aug 20, 2024
| /// </summary> | ||
| public override JToken? GenerateJToken(object? value) | ||
| { | ||
| // This is a hack to allow both arrays and ROM types without different function overloads or type mappings. |
There was a problem hiding this comment.
Doesn't actually seem all that hacky to me! We basically need to do ToArray() because the Cosmos SDK doesn't (yet) natively support ROM, right?
There was a problem hiding this comment.
It's hacky in the sense that a type mapping with a converter should always be able to pass its value to that converter, but in this case we're using the same type mapping for values that may or may not need converting.
ajcvickers
force-pushed
the
CosmosVectorStuff
branch
from
5136903
to
c8a5471
Compare
|
@roji I tweaked the query changes to fix the failing tests. Can you have a quick look? |
roji
commented
Aug 21, 2024
src/EFCore.Cosmos/Query/Internal/CosmosSqlTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
ajcvickers
approved these changes
Aug 21, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ajcvickers
added a commit
that referenced
this pull request
Aug 21, 2024
Fixes #34402 Co-authored-by: Arthur Vickers <ajcvickers@hotmail.com>
ajcvickers
added a commit
that referenced
this pull request
Aug 21, 2024
Fixes #34402 Co-authored-by: Arthur Vickers <ajcvickers@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a targeted fix to Cosmos, to strip convert nodes out which represent implicit conversions.
I think we need to revisit our general casting/conversion strategy (across both Cosmos and relational), but this specific change makes sense to me...
@ajcvickers can you verify that all vector search tests now pass?