Unify OS version xunit attributes #2481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anurse test infrastructure improvements that support 3.1 feature work. |
|
Infra-only is tell mode for 3.1 anyway, so I'm fine with this (once approved, green builds, etc.). |
JunTaoLuo
pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 12, 2020
\n\nCommit migrated from dotnet/extensions@65e70f5
JunTaoLuo
pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 15, 2020
\n\nCommit migrated from dotnet/extensions@65e70f5
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
Commit migrated from dotnet/extensions@65e70f5
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
Commit migrated from dotnet/extensions@65e70f5
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 27, 2020
Commit migrated from dotnet/extensions@65e70f5
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that me of last week thinks a lot like me of last year.
#2449 added OSMinVersionAttribute, but last year I added MinimumOSVersionAttribute that does almost the same thing. The main functional difference is that the old one didn't distinguish between win10 versions. The old one also did registry checks that are no longer needed.
At least I've improved as a developer since last year 😁, this time there were test, more granular version checks, etc..
This PR merges the new attribute back into the old one with code improvements and applies the new tests to the old attribute.