Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable partial type checking when getting full results for a file or project #10448

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

TIHan
Copy link
Contributor

@TIHan TIHan commented Nov 12, 2020

I noticed a minor issue where we could be type-checking more than we wanted.

Before, when we did a find-all-refs on a file that hasn't already been checked, it would check it twice: one for a partial, and one for the full. Now, it will do it just for full.

This solution isn't perfect, but it addresses the extra type-check.

@TIHan
Copy link
Contributor Author

TIHan commented Nov 19, 2020

@cartermp could you take a look at this one

@TIHan TIHan merged commit 8f6e2b7 into dotnet:main Nov 25, 2020
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants