Fix net sdk references discovery #10569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
reviewed
Nov 30, 2020
| let version, frameworkRefsPackDirectoryRoot = | ||
| try | ||
| let version = DirectoryInfo(implementationAssemblyDir).Name | ||
| let microsoftNETCoreAppRef = Path.Combine(implementationAssemblyDir, "../../../packs/Microsoft.NETCore.App.Ref") | ||
| if Directory.Exists(microsoftNETCoreAppRef) then | ||
| Some version, Some microsoftNETCoreAppRef | ||
| let directory = DirectoryInfo(microsoftNETCoreAppRef).GetDirectories() | ||
| |> Array.sortBy (fun di -> di.Name) |
There was a problem hiding this comment.
This should really be a semver comparison, but that gets nasty so I suppose this is good enough.
Could you check this, though, with a purposely badly named runtime dir name? I commonly pretend to remove, e.g., the 3.1.2 dir by renaming it to brettfo_3.1.2.
There was a problem hiding this comment.
Yes numbers are better than string comparisons. I will change it.
brettfo
approved these changes
Dec 1, 2020
laenas
pushed a commit
to laenas/fsharp
that referenced
this pull request
Dec 1, 2020
* Fix net sdk references discovery * Do numbers properly * version filter
laenas
pushed a commit
to laenas/fsharp
that referenced
this pull request
Dec 1, 2020
* Fix net sdk references discovery * Do numbers properly * version filter
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* Fix net sdk references discovery * Do numbers properly * version filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original algorithm for mapping NETSdk pack locations from the implementation directoy was incorrect.
We now compute the NETSdk reference assembly to be the highest version that is lower or equal to the implementation version.