Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get/set to item description tooltip #7016

Merged
merged 4 commits into from
Jun 20, 2019
Merged

Add get/set to item description tooltip #7016

merged 4 commits into from
Jun 20, 2019

Conversation

cartermp
Copy link
Contributor

Fixes #7007 by adding an additional section in the formatted tooltip text for properties that indicates if it is a getter, setter, or both.

Using this code:

type C() =
    member __.GetOnly = 3
    member __.GetSet with get () = () and set () = ()
    member __.SetOnly with set () = ()

let c = C()

Getter:

image

Setter:

image

Both:

image

@cartermp
Copy link
Contributor Author

cc @Happypig375

src/fsharp/NicePrint.fs Outdated Show resolved Hide resolved
src/fsharp/NicePrint.fs Outdated Show resolved Hide resolved
Copy link
Member

@Happypig375 Happypig375 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to help everyone a lot! 👍❤️🚀

src/fsharp/NicePrint.fs Outdated Show resolved Hide resolved
@cartermp
Copy link
Contributor Author

Ready to merge when this passes. I walked through all examples in this doc to verify it all shows appropriately: https://docs.microsoft.com/en-us/dotnet/fsharp/language-reference/members/properties

@TIHan TIHan merged commit 51684d4 into dotnet:master Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Viewing whether a property is get-only, get-set, or set-only
5 participants