Michal mocarski's fix #8498
Merged
Michal mocarski's fix #8498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It cancels significant version numbers if they're preceeded by zeros and can lead to inconsistency between product version and file version.
KevinRansom
force-pushed
the
michalmocarski
branch
from
e1647c4
to
0d56181
Compare
brettfo
approved these changes
Feb 7, 2020
cartermp
reviewed
Feb 7, 2020
TIHan
approved these changes
Feb 7, 2020
cartermp
approved these changes
Feb 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I messed up modifying this PR: #7884
Anyway his commits are still here :-)