Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wild self id pat range #8635

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

auduchinok
Copy link
Member

@auduchinok auduchinok commented Feb 27, 2020

Fixes problems with _ self id ranges in members (from #7631). The added rule was copied from existing one and some of its parts didn't have indices properly updated.

@auduchinok auduchinok force-pushed the member-wildSelfId-range branch 2 times, most recently from 0ef7dbe to 9b7d304 Compare February 27, 2020 18:58
@auduchinok auduchinok changed the title Fix wild self id pat range, simplify grammar Fix wild self id pat range Feb 27, 2020
Copy link
Member

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice,

thank you for this.

@cartermp cartermp merged commit 808996b into dotnet:master Feb 28, 2020
@auduchinok auduchinok deleted the member-wildSelfId-range branch February 28, 2020 11:23
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants