Skip to content

Commit

Permalink
React to TraceEvent Refactoring (#4314)
Browse files Browse the repository at this point in the history
  • Loading branch information
@cshung
cshung committed Jul 17, 2024
1 parent 1dbbe1d commit 40478a4
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 19 deletions.
22 changes: 11 additions & 11 deletions src/benchmarks/gc/GC.Infrastructure/GC.Analysis.API.UnitTests/DynamicEventTests.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -150,13 +150,13 @@ public void TestSmallerMaxOccurrence()
},
};

private DynamicEvent sampleEvent = new DynamicEvent(
private GCDynamicEvent sampleEvent = new GCDynamicEvent(
"SampleEventName",
DateTime.Now,
new byte[] { 1, 0, 2, 0, 0, 0, 0, 0, 0, 0 }
);

private DynamicEvent unknownEvent = new DynamicEvent(
private GCDynamicEvent unknownEvent = new GCDynamicEvent(
"UnknownEventName",
DateTime.Now,
new byte[] { 1, 0, 2, 0, 0, 0, 0, 0, 0, 0 }
Expand All @@ -166,7 +166,7 @@ public void TestSmallerMaxOccurrence()
public void TestMissedSingleEvent()
{
DynamicEventSchema.Set(correctSingleSchema);
List<DynamicEvent> dynamicEvents = new List<DynamicEvent>();
List<GCDynamicEvent> dynamicEvents = new List<GCDynamicEvent>();
Action test = () =>
{
dynamic index = new DynamicIndex(dynamicEvents);
Expand All @@ -178,7 +178,7 @@ public void TestMissedSingleEvent()
public void TestDuplicatedSingleEvent()
{
DynamicEventSchema.Set(correctSingleSchema);
List<DynamicEvent> dynamicEvents = new List<DynamicEvent>
List<GCDynamicEvent> dynamicEvents = new List<GCDynamicEvent>
{
sampleEvent,
sampleEvent
Expand All @@ -194,7 +194,7 @@ public void TestDuplicatedSingleEvent()
public void TestSingleEvent()
{
DynamicEventSchema.Set(correctSingleSchema);
List<DynamicEvent> dynamicEvents = new List<DynamicEvent>
List<GCDynamicEvent> dynamicEvents = new List<GCDynamicEvent>
{
sampleEvent
};
Expand Down Expand Up @@ -230,7 +230,7 @@ public void TestSingleEvent()
public void TestMissedMultipleEvent()
{
DynamicEventSchema.Set(correctMultipleSchema);
List<DynamicEvent> dynamicEvents = new List<DynamicEvent>();
List<GCDynamicEvent> dynamicEvents = new List<GCDynamicEvent>();
Action test = () =>
{
dynamic index = new DynamicIndex(dynamicEvents);
Expand All @@ -242,7 +242,7 @@ public void TestMissedMultipleEvent()
public void TestTooManyMultipleEvents()
{
DynamicEventSchema.Set(correctMultipleSchema);
List<DynamicEvent> dynamicEvents = new List<DynamicEvent>
List<GCDynamicEvent> dynamicEvents = new List<GCDynamicEvent>
{
sampleEvent,
sampleEvent,
Expand All @@ -259,7 +259,7 @@ public void TestTooManyMultipleEvents()
public void TestMultipleEvents()
{
DynamicEventSchema.Set(correctMultipleSchema);
List<DynamicEvent> dynamicEvents = new List<DynamicEvent>
List<GCDynamicEvent> dynamicEvents = new List<GCDynamicEvent>
{
sampleEvent,
sampleEvent,
Expand Down Expand Up @@ -289,7 +289,7 @@ public void TestOptionalEvent()
},
}
);
List<DynamicEvent> dynamicEvents = new List<DynamicEvent>();
List<GCDynamicEvent> dynamicEvents = new List<GCDynamicEvent>();
dynamic index = new DynamicIndex(dynamicEvents);
((bool)(index.SampleEventName == null)).Should().Be(true);
}
Expand All @@ -298,7 +298,7 @@ public void TestOptionalEvent()
public void TestForgivingUnknownEvent()
{
DynamicEventSchema.Set(correctSingleSchema);
List<DynamicEvent> dynamicEvents = new List<DynamicEvent>
List<GCDynamicEvent> dynamicEvents = new List<GCDynamicEvent>
{
sampleEvent,
unknownEvent
Expand All @@ -311,7 +311,7 @@ public void TestForgivingUnknownEvent()
public void TestReportingUnknownEvent()
{
DynamicEventSchema.Set(correctSingleSchema, false);
List<DynamicEvent> dynamicEvents = new List<DynamicEvent>
List<GCDynamicEvent> dynamicEvents = new List<GCDynamicEvent>
{
sampleEvent,
unknownEvent
Expand Down
16 changes: 8 additions & 8 deletions src/benchmarks/gc/GC.Infrastructure/GC.Analysis.API/DynamicEvents/DynamicEvents.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -127,17 +127,17 @@ internal sealed class DynamicIndex : DynamicObject
{
private readonly Dictionary<string, object?> index;

public DynamicIndex(List<DynamicEvent> dynamicEvents)
public DynamicIndex(List<GCDynamicEvent> dynamicEvents)
{
this.index = new Dictionary<string, object?>();
Dictionary<string, List<DynamicEvent>> indexedEvents = new Dictionary<string, List<DynamicEvent>>();
Dictionary<string, List<GCDynamicEvent>> indexedEvents = new Dictionary<string, List<GCDynamicEvent>>();
foreach (string eventName in DynamicEventSchema.DynamicEventSchemas.Keys)
{
indexedEvents.Add(eventName, new List<DynamicEvent>());
indexedEvents.Add(eventName, new List<GCDynamicEvent>());
}
foreach (DynamicEvent dynamicEvent in dynamicEvents)
foreach (GCDynamicEvent dynamicEvent in dynamicEvents)
{
List<DynamicEvent>? dynamicEventList;
List<GCDynamicEvent>? dynamicEventList;
if (indexedEvents.TryGetValue(dynamicEvent.Name, out dynamicEventList))
{
dynamicEventList.Add(dynamicEvent);
Expand All @@ -152,7 +152,7 @@ public DynamicIndex(List<DynamicEvent> dynamicEvents)
}
foreach (string eventName in DynamicEventSchema.DynamicEventSchemas.Keys)
{
List<DynamicEvent> eventList = indexedEvents[eventName];
List<GCDynamicEvent> eventList = indexedEvents[eventName];
CompiledSchema schema = DynamicEventSchema.DynamicEventSchemas[eventName];
if (eventList.Count > schema.MaxOccurrence)
{
Expand All @@ -176,7 +176,7 @@ public DynamicIndex(List<DynamicEvent> dynamicEvents)
else
{
List<DynamicEventObject> output = new List<DynamicEventObject>();
foreach (DynamicEvent dynamicEvent in eventList)
foreach (GCDynamicEvent dynamicEvent in eventList)
{
output.Add(new DynamicEventObject(dynamicEvent, schema));
}
Expand All @@ -196,7 +196,7 @@ internal sealed class DynamicEventObject : DynamicObject
private string name;
private Dictionary<string, object> fieldValues;

public DynamicEventObject(DynamicEvent dynamicEvent, CompiledSchema schema)
public DynamicEventObject(GCDynamicEvent dynamicEvent, CompiledSchema schema)
{
this.name = dynamicEvent.Name;
this.fieldValues = new Dictionary<string, object>();
Expand Down

0 comments on commit 40478a4

Please sign in to comment.