Avoid unnecessary M.VisualBasic and S.ValueTuple dependencies #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found in dotnet/runtime#96795 (comment) These packages shouldn't be referenced on modern TFMs as the types are already provided inbox by the framework.
akoeplinger
reviewed
Jan 24, 2024
...sting/Microsoft.CodeAnalysis.Analyzer.Testing/Microsoft.CodeAnalysis.Analyzer.Testing.csproj
Show resolved
Hide resolved
akoeplinger
approved these changes
Jan 24, 2024
It's a testing package that supports testing Roslyn 1.x analyzers in Visual Studio 2015. |
sharwell
approved these changes
Jan 24, 2024
Tactics though decided that we're dropping support for older TFMs in our core packages going forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found in dotnet/runtime#96795 (comment)
These packages shouldn't be referenced on modern TFMs as the types are already provided inbox by the framework.
FWIW, I'm not sure why roslyn-sdk targets out-of-support TFMs like net452 or net46: https://learn.microsoft.com/de-de/lifecycle/products/microsoft-net-framework. That goes against what Tactics agreed on in November. See https://github.com/dotnet/designs-microsoft/pull/74 for more details.