Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly implement type inference for C# member access expressions. #12110

Merged
merged 11 commits into from
Jun 21, 2016
Merged

Properly implement type inference for C# member access expressions. #12110

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
29c11cd
Properly implement type inference for C# member access expressions.
CyrusNajmabadi Jun 20, 2016
045003e
Add VB side.
CyrusNajmabadi Jun 20, 2016
1e4027f
Share comment.
CyrusNajmabadi Jun 20, 2016
91cad67
More VB side.
CyrusNajmabadi Jun 20, 2016
41a1d64
Fix inference in awaits.
CyrusNajmabadi Jun 20, 2016
b35bac4
Merge branch 'master' into typeInferenceWork
CyrusNajmabadi Jun 21, 2016
f29a6cb
Add better inference for task and enumerable scenarios.
CyrusNajmabadi Jun 21, 2016
6bdb5a5
VB side of type inference.
CyrusNajmabadi Jun 21, 2016
e11beed
Fix test.
CyrusNajmabadi Jun 21, 2016
3491dd2
Only consider identifiers that bind to lambda parameters.
CyrusNajmabadi Jun 21, 2016
a5b8071
Add test.
CyrusNajmabadi Jun 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test.
  • Loading branch information
@CyrusNajmabadi
CyrusNajmabadi committed Jun 21, 2016
commit e11beed3eff074a49a14b607833f6561dd3a1577
17 changes: 15 additions & 2 deletions src/EditorFeatures/CSharpTest/Diagnostics/GenerateMethod/GenerateMethodTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2766,7 +2766,15 @@ static void Main ( string [ ] args ) {
bool x = await [|Foo|] ( ) . ConfigureAwait ( false ) ;
}
}",
@"using System ; using System . Collections . Generic ; using System . Linq ; using System . Threading . Tasks ; class Program { static void Main ( string [ ] args ) { bool x = await Foo ( ) . ConfigureAwait ( false ) ; } private static Task < bool > Foo ( ) { throw new NotImplementedException ( ) ; } } ");
@"using System ;
using System . Collections . Generic ;
using System . Linq ;
using System . Threading . Tasks ;
class Program {
static void Main ( string [ ] args ) {
bool x = await Foo ( ) . ConfigureAwait ( false ) ;
}
private static Task < bool > Foo ( ) { throw new NotImplementedException ( ) ; } } ");
}

[WorkItem(643, "https://github.com/dotnet/roslyn/issues/643")]
Expand All @@ -2781,7 +2789,12 @@ static async void T ( ) {
bool x = await [|M|] ( ) . ContinueWith ( a => { return true ; } ) . ContinueWith ( a => { return false ; } ) ;
}
} ",
@"using System ; using System . Threading . Tasks ; class C { static async void T ( ) { bool x = await M ( ) . ContinueWith ( a => { return true ; } ) . ContinueWith ( a => { return false ; } ) ; } private static object M ( ) { throw new NotImplementedException ( ) ; } } ");
@"using System ;
using System . Threading . Tasks ;
class C {
static async void T ( ) {
bool x = await M ( ) . ContinueWith ( a => { return true ; } ) . ContinueWith ( a => { return false ; } ) ; }
private static Task<object> M ( ) { throw new NotImplementedException ( ) ; } } ");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now infers object instead of bool?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as below I guess.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The inference of 'bool' was specious. It basically was saying the equivalent of: i have "bool b = x.y.z", ergo 'x' and 'y' are bool". This simply is not an accurate or appropriate inference to make.

}

[WorkItem(529480, "http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/529480")]
Expand Down