Tagging VB/C# Ioperation tests #21310
Conversation
| @@ -12,6 +12,7 @@ namespace Microsoft.CodeAnalysis.CSharp.UnitTests | |||
| { | |||
| public partial class IOperationTests : SemanticModelTestBase | |||
| { | |||
| [CompilerTrait(CompilerFeature.IOperation)] | |||
There was a problem hiding this comment.
For tuple tests, I opted to put the trait on the class rather than individual tests, where possible. I'd suggest the same here, since the whole file is dedicated to IOperations tests.
There was a problem hiding this comment.
That is true for most of the files here, tomorrow if you add more tests for other scenario will we go remember to split it ?
There was a problem hiding this comment.
I haven't seen trait on class. I think majority of roslyn tests' traits are on each test methods.
There was a problem hiding this comment.
Up to you. Doesn't seem like like this file would contain tests other than IOperation...
There was a problem hiding this comment.
I prefer traits per unit tests
| using Roslyn.Test.Utilities; | ||
| using Xunit; | ||
|
|
||
| namespace Microsoft.CodeAnalysis.CSharp.UnitTests | ||
| { | ||
| public partial class IOperationTests : SemanticModelTestBase | ||
| { | ||
| [CompilerTrait(CompilerFeature.Determinism)] |
There was a problem hiding this comment.
Why determinism? Copy & paste error?
There was a problem hiding this comment.
yes , thatz a copy paste error ..will fix
|
test this please |
1 similar comment
|
test this please |
|
test this please |
…sion-expression-rewrite * dotnet/features/ioperation: Tagging VB/C# Ioperation tests (dotnet#21310)
fixes #20652
@jcouv , @dotnet/analyzer-ioperation