Be resilient to getting busy messages back from sqlite while retrieving data. #21800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng the string table.
|
Tagging @dotnet/roslyn-ide |
|
Tagging @dpoeschl |
|
tagging @heejaechang |
heejaechang
approved these changes
Aug 30, 2017
heejaechang
reviewed
Aug 30, 2017
| { | ||
| var statement = resettableStatement.Statement; | ||
| while (statement.Step() == Result.ROW) | ||
| using (var resettableStatement = connection.GetResettableStatement( |
There was a problem hiding this comment.
so issue was we not releasing this resource?
There was a problem hiding this comment.
No. Issue was leaking out a "busy" exception.
sharwell
pushed a commit
to sharwell/roslyn
that referenced
this pull request
Oct 12, 2017
…to dotnet/dev15.4.x Be resilient to getting busy messages back from sqlite while retrieving data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems?id=452360&fullScreen=true&_a=edit
Note: this issue should happen a lot less in 15.5 as heejae made a change in #21532 to have separate DBs for VS and for the OOP process. Without having two processes hitting the same DB, there should be a lot less contention on the DB and busy exceptions should be much rarer.
Also, because we enabled WAL (write ahead logging) busy errors happen far less: https://sqlite.org/wal.html
"The second advantage of WAL-mode is that writers do not block readers and readers to do not block writers. "