Portable emit tests #25459
Portable emit tests #25459
Conversation
| @@ -1,5 +1,5 @@ | |||
| // Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. | |||
|
|
|||
| #if NET461 | |||
There was a problem hiding this comment.
Why are all these #if necessary? These tests are all compiling today
|
test windows_debug_unit32_prtest please |
|
Why the “#if” blocks. These shouldn’t be necessary. |
|
Don't think these commits of mine should be cherry-picked. Several of them have already largely been undone by later changes in dev15.7.x. I'm going to send an email out shortly to swat to try and figure out why the the merge dev15.7.x to master isn't working. |
|
Apparently the That indicates more commits are missing from master. |
|
@tmat check your inbox. I'm not sure what is going on here or what we merged at this point. |
|
@tmat we've all sync'd up. Proceed with the revert. The |
|
retest windows_debug_unit64_prtest please |
|
test windows_debug_vs-integration_prtest please |
|
test windows_release_vs-integration_prtest please |
|
test windows_debug_vs-integration_prtest please |
|
Looks like the windows_coreclr_test_prtest is in a zombie state. That job was renamed in a recent change to netci.groovy. Every other leg is passing. Let me know when you're ready to merge and I'll override the required flag for this leg. |
|
@jaredpar I think it's good to go. |
Fix dev15.7.x to master merge issues.