Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional tests for Expression Variables feature #25519

Conversation

AlekseyTs
Copy link
Contributor

No description provided.

@AlekseyTs
Copy link
Contributor Author

CC @gafter

@gafter gafter mentioned this pull request Mar 16, 2018
44 tasks
@AlekseyTs AlekseyTs added this to the 15.7 milestone Mar 16, 2018
@AlekseyTs
Copy link
Contributor Author

@dotnet/roslyn-compiler Please review, test-only change

@AlekseyTs AlekseyTs added the Test Test failures in roslyn-CI label Mar 16, 2018
{
public Y(object y) {}
}
";
Copy link
Member

@cston cston Mar 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we testing references (presumably invalid) across fields?

static bool Test7 = TakeOutParam(out x6, 7);
``` #Resolved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we testing references (presumably invalid) across fields?

See in Scope_FieldInitializers_01

    bool Test71 = TakeOutParam(7, out int x7) && x7 > 0; 
    bool Test72 = Dummy(x7, 2); 

In reply to: 175110611 [](ancestors = 175110611)

Copy link
Member

@gafter gafter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

// Code size 2 (0x2)
.maxstack 1
.locals init (int V_0) //x1
IL_0000: ldloc.0
Copy link
Member

@gafter gafter Mar 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ldloc [](start = 12, length = 5)

It might be nice to dump the IL for the .ctor so we can see that this is the right local. #Resolved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice to dump the IL for the .ctor so we can see that this is the right local.

I think this .locals init (int V_0) //x1 is good enough for that and there are no other locals in this constructor


In reply to: 175124964 [](ancestors = 175124964)

@AlekseyTs AlekseyTs merged commit 66df38c into dotnet:features/ExpressionVariables Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers New Language Feature - Out Variable Declaration Out Variable Declaration Test Test failures in roslyn-CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants