-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional tests for Expression Variables feature #25519
Additional tests for Expression Variables feature #25519
Conversation
CC @gafter |
@dotnet/roslyn-compiler Please review, test-only change |
{ | ||
public Y(object y) {} | ||
} | ||
"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we testing references (presumably invalid) across fields?
static bool Test7 = TakeOutParam(out x6, 7);
``` #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we testing references (presumably invalid) across fields?
See in Scope_FieldInitializers_01
bool Test71 = TakeOutParam(7, out int x7) && x7 > 0;
bool Test72 = Dummy(x7, 2);
In reply to: 175110611 [](ancestors = 175110611)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Code size 2 (0x2) | ||
.maxstack 1 | ||
.locals init (int V_0) //x1 | ||
IL_0000: ldloc.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ldloc [](start = 12, length = 5)
It might be nice to dump the IL for the .ctor so we can see that this is the right local. #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be nice to dump the IL for the .ctor so we can see that this is the right local.
I think this .locals init (int V_0) //x1
is good enough for that and there are no other locals in this constructor
In reply to: 175124964 [](ancestors = 175124964)
No description provided.