Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unreachable code. #25575

Merged
merged 1 commit into from
Mar 19, 2018
Merged

Remove unreachable code. #25575

merged 1 commit into from
Mar 19, 2018

Conversation

AdamSpeight2008
Copy link
Contributor

As all branches of the conditional return before reaching them.

@AdamSpeight2008 AdamSpeight2008 requested a review from a team as a code owner March 18, 2018 22:00
AlekseyTs
AlekseyTs approved these changes Mar 19, 2018
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (iteration 1)

@AlekseyTs AlekseyTs merged commit f4d08be into dotnet:master Mar 19, 2018
@AlekseyTs
Copy link
Contributor

@AdamSpeight2008 Thanks for the contribution.

@AdamSpeight2008 AdamSpeight2008 deleted the ParseXML_Unreachable branch March 19, 2018 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredpar jaredpar jaredpar approved these changes

@AlekseyTs AlekseyTs AlekseyTs approved these changes

@cston cston cston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AdamSpeight2008 @AlekseyTs @jaredpar @cston