Add a Jenkins leg to check for loc changes #28721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test ci please |
|
|
||
| # Find the merge base, then the list of files that changed since then. | ||
| $mergeBase = & git merge-base $base $head | ||
| $changedFiles = @(& git diff --name-only $mergeBase $head) |
There was a problem hiding this comment.
You should be able to stick -- *.xlf at the end of the git diff, so then git will filter to just edits to .xlf files.
jasonmalinowski
approved these changes
Jul 19, 2018
|
test loc changes |
tmeschter
force-pushed
the
LocBlockScript-180719
branch
from
cc999ed
to
a73140e
Compare
|
test ci please |
Add a Jenkins leg to check for loc changes. Once we're past the loc freeze date for a release branch we want to block any PRs that modify .xlf files. Note that we *do* need a way to let updates from the Loc team through, but that is not addressed by this change.
tmeschter
force-pushed
the
LocBlockScript-180719
branch
from
a73140e
to
022ee37
Compare
|
test ci please |
1 similar comment
|
test ci please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Jenkins leg to check for loc changes. Once we're past the loc
freeze date for a release branch we want to block any PRs that modify
.xlf files.
Note that we do need a way to let updates from the Loc team through,
but that is not addressed by this change.