-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use native azdo command for checkout #61965
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Matt!
eng/pipelines/checkout-unix-task.yml
Outdated
displayName: Shallow Checkout | ||
- checkout: self | ||
clean: true | ||
fetchDepth: 1 # Fetch only one commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad they added this.
Does this avoid tags as well? We have a decent number of them. |
Looking at the logs, no, it does not avoid tags. |
Doesn't appear to be an option either - https://docs.microsoft.com/en-us/azure/devops/pipelines/yaml-schema/steps-checkout?view=azure-pipelines |
I'm trying to figure out where to submit a PR or add a request. I wouldn't block on removing the manual checkout for this though. |
https://developercommunity.visualstudio.com/t/Add-support-to-avoid-fetching-tags-in-Az/10073567 Upvotes would be appreciated. I took a stab at the sources and there is a ton of complexity (perhaps due to going back to older versions of VSTS and such) |
up dooted |
Is this solving a correctness issue? At a glance this still appears to be 3-4x slower than the shallow checkout that we do currently. That difference is less than 2 minutes, granted. |
This was a reaction to, earlier in the day, |
Up to you guys whether you take it. Git was removed on purpose from the images with VS on them: dotnet/arcade#9166 |
Let's merge this to resolve the current CI failures in main. Thanks @mmitche! |
This reverts commit c138408.
No description provided.