Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native azdo command for checkout #61965

Merged
merged 2 commits into from
Jun 18, 2022

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Jun 16, 2022

No description provided.

eng/pipelines/checkout-unix-task.yml Outdated Show resolved Hide resolved
Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matt!

displayName: Shallow Checkout
- checkout: self
clean: true
fetchDepth: 1 # Fetch only one commit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad they added this.

@333fred
Copy link
Member

333fred commented Jun 16, 2022

Does this avoid tags as well? We have a decent number of them.

@michellemcdaniel
Copy link

Does this avoid tags as well? We have a decent number of them.

Looking at the logs, no, it does not avoid tags.

@JoeRobich
Copy link
Member

Does this avoid tags as well? We have a decent number of them.

Doesn't appear to be an option either - https://docs.microsoft.com/en-us/azure/devops/pipelines/yaml-schema/steps-checkout?view=azure-pipelines

@mmitche
Copy link
Member Author

mmitche commented Jun 16, 2022

Does this avoid tags as well? We have a decent number of them.

Doesn't appear to be an option either - https://docs.microsoft.com/en-us/azure/devops/pipelines/yaml-schema/steps-checkout?view=azure-pipelines

I'm trying to figure out where to submit a PR or add a request. I wouldn't block on removing the manual checkout for this though.

@mmitche
Copy link
Member Author

mmitche commented Jun 16, 2022

https://developercommunity.visualstudio.com/t/Add-support-to-avoid-fetching-tags-in-Az/10073567

Upvotes would be appreciated. I took a stab at the sources and there is a ton of complexity (perhaps due to going back to older versions of VSTS and such)

@michellemcdaniel
Copy link

up dooted

@RikkiGibson
Copy link
Contributor

Is this solving a correctness issue? At a glance this still appears to be 3-4x slower than the shallow checkout that we do currently. That difference is less than 2 minutes, granted.

@mmitche
Copy link
Member Author

mmitche commented Jun 16, 2022

Is this solving a correctness issue? At a glance this still appears to be 3-4x slower than the shallow checkout that we do currently. That difference is less than 2 minutes, granted.

This was a reaction to, earlier in the day, git was not on the path on Windows machines

@mmitche
Copy link
Member Author

mmitche commented Jun 17, 2022

Is this solving a correctness issue? At a glance this still appears to be 3-4x slower than the shallow checkout that we do currently. That difference is less than 2 minutes, granted.

Up to you guys whether you take it. Git was removed on purpose from the images with VS on them: dotnet/arcade#9166

@RikkiGibson
Copy link
Contributor

RikkiGibson commented Jun 18, 2022

Let's merge this to resolve the current CI failures in main. Thanks @mmitche!

@RikkiGibson RikkiGibson merged commit c138408 into dotnet:main Jun 18, 2022
@ghost ghost added this to the Next milestone Jun 18, 2022
RikkiGibson added a commit that referenced this pull request Jun 18, 2022
@RikkiGibson RikkiGibson modified the milestones: Next, 17.3 P3 Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants