Only pack the shipping/non-shipping nupkgs for roslyn #67679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid packing release, pre-release stable nupkgs, and symbol nupkgs
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
ghost
added
the
Community
|
FYI @Forgind. Note this also makes roslyn's intermediate nupkg a 3rd of its former size. |
jaredpar
reviewed
Apr 17, 2023
| <ItemGroup> | ||
| <IntermediateNupkgArtifactFile Include="$(CurrentRepoSourceBuildArtifactsPackagesDir)Shipping\**\*.nupkg" /> | ||
| <IntermediateNupkgArtifactFile Include="$(CurrentRepoSourceBuildArtifactsPackagesDir)NonShipping\**\*.nupkg" /> | ||
| <!-- Don't pack any symbol packages: not needed for downstream source-build CI. |
There was a problem hiding this comment.
How does this stop us from packing?
There was a problem hiding this comment.
c6b058c#diff-6a28d92de8923be8821f2123541dc23c8ad0359c96117709e6d49e752c0303d2R9
This prevents the defaults (whole packages dir) from being included.
|
@jaredpar Any further concerns here? |
jaredpar
approved these changes
Apr 25, 2023
|
@mmitche - I'm seeing a similar issue with F# packages. |
|
ping - any update on this PR? Would be nice to get this merged in for source-build. TIA |
333fred
approved these changes
May 22, 2023
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid packing release, pre-release stable nupkgs, and symbol nupkg.
Without this change, source build was preferencing the stable, release nupkgs when flowing between the repos. This worked until a new property showed up in the SDK bundled version props which is the net compiler toolset version. This should always be the non-stable version, based on the fact that this is the version used in the Microsoft build.