Remove CPD attribute on DiaSymReader dependency #68523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This breaks coherency, because roslyn @ 5d10d42 does not have a dependency on DiaSymReader, so this coherency restriction is unresolvable. I don't think this was intended. Furthermore, even if roslyn did have such a dependency, it would freeze this version in place, because in order to update DiaSymReader, you would have to first make it incoherency (manually edit the version), then immediately flow roslyn to itself. Otherwise, Maestro would simply change things back.
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
ghost
added
the
Community
|
@333fred This is also blocking arcade updates I think. |
jaredpar
reviewed
Jun 9, 2023
| @@ -28,7 +28,7 @@ | |||
| <Sha>3f43bf1b2dead2cb51f20dc47f6dfd7981248820</Sha> | |||
| <SourceBuild RepoName="sourcelink" ManagedOnly="true" /> | |||
| </Dependency> | |||
| <Dependency Name="Microsoft.DiaSymReader" Version="2.0.0" CoherentParentDependency="Microsoft.Net.Compilers.Toolset"> | |||
There was a problem hiding this comment.
What does this attribute even mean????
There was a problem hiding this comment.
It means that DiaSymReader's version should be taken from the version that roslyn depends on at the sha from Microsoft.NET.Compilers.Toolset:
That creates a nice circular reference you can't update, and besides that, roslyn doesn't depend on DiaSymReader there.
333fred
approved these changes
Jun 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks coherency, because roslyn @ 5d10d42 does not have a dependency on DiaSymReader, so this coherency restriction is unresolvable.
I don't think this was intended.
Furthermore, even if roslyn did have such a dependency, it would freeze this version in place, because in order to update DiaSymReader, you would have to first make it incoherency (manually edit the version), then immediately flow roslyn to itself. Otherwise, Maestro would simply change things back.