Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra backslash from IBC script #71264

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Dec 14, 2023

This should not be necessary and can cause problems with the inner build in Vertical Build by escaping a trailing quote. RepoRoot is already passed with a trailing slash.

This should not be necessary and causes problems with the inner build in Vertical Build. RepoRoot is already passed with a trailing slash.
@mmitche mmitche requested a review from a team as a code owner December 14, 2023 18:41
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Dec 14, 2023
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Dec 14, 2023
@mmitche
Copy link
Member Author

mmitche commented Dec 15, 2023

@jasonmalinowski good to merge around the integration failures?

@jasonmalinowski
Copy link
Member

@mmitche You should be; if you need me to bypass and hit merge ping me over Teams.

@mmitche mmitche merged commit 0a8c34e into dotnet:main Dec 15, 2023
22 of 27 checks passed
@ghost ghost added this to the Next milestone Dec 15, 2023
@Cosifne Cosifne modified the milestones: Next, 17.9 P3 Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants